Skip to content

Conversation

staticfloat
Copy link
Contributor

This fixes issues Flux is having right now

@codecov-io
Copy link

codecov-io commented Dec 23, 2019

Codecov Report

Merging #153 into master will decrease coverage by 0.45%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   74.86%   74.41%   -0.46%     
==========================================
  Files          24       24              
  Lines         768      774       +6     
==========================================
+ Hits          575      576       +1     
- Misses        193      198       +5
Impacted Files Coverage Δ
src/impl/depthwiseconv_direct.jl 95.91% <ø> (ø) ⬆️
src/conv.jl 91.66% <ø> (ø) ⬆️
src/impl/depthwiseconv_im2col.jl 100% <ø> (ø) ⬆️
src/nnpack/libnnpack.jl 30.9% <100%> (ø) ⬆️
src/pooling.jl 95.45% <100%> (ø) ⬆️
src/nnpack/interface.jl 93.75% <66.66%> (-6.25%) ⬇️
src/impl/conv_im2col.jl 94.68% <0%> (-4.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cfd08a...9df3631. Read the comment docs.

@DhairyaLGandhi
Copy link
Member

Looks good, thanks @staticfloat !

@DhairyaLGandhi DhairyaLGandhi merged commit 480754a into master Dec 23, 2019
@DhairyaLGandhi
Copy link
Member

Hmm, seems there is an inference failure, shouldn't have been trigger happy with the merge. Will need looking into

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants